fix(OpenUI5Support): override default [popover] styles #12301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes styling issues with OpenUI5 popover support by overriding default browser popover styles that were interfering with OpenUI5 popup positioning and appearance.
- Introduces a new CSS file with default popover style overrides
- Adds functionality to insert these styles when patching OpenUI5 popups
- Integrates the style insertion into the existing popup patching workflow
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/base/src/features/patchPopup.ts | Imports and calls the new style insertion function during popup patching |
| packages/base/src/features/insertOpenUI5PopupStyles.ts | New utility function to conditionally insert OpenUI5 popup styles |
| packages/base/src/css/OpenUI5PopupStyles.css | New CSS file containing popover style overrides (border, overflow, margin) |
nnaydenow
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: BGSOFUIRODOPI-3523
SNOW: DINC0603221